Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set semantic type as CI and include digests as CI operations #13644

Closed
wants to merge 2 commits into from

Conversation

cmeister2
Copy link
Contributor

@cmeister2 cmeister2 commented May 14, 2024

Hopefully removing the last of the "chores" from Renovate.

@cmeister2 cmeister2 requested a review from bagder May 14, 2024 16:06
@github-actions github-actions bot added the CI Continuous Integration label May 14, 2024
renovate.json Outdated Show resolved Hide resolved
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the little nit, this looks good

@cmeister2
Copy link
Contributor Author

Fix pushed, will merge after checks complete.

@jay
Copy link
Member

jay commented May 15, 2024

usually in a pr you would squash your incremental work together into one commit, unless they are truly separate, and then rebase before landing. you can judge whether that is the case here. your commit will need an explanation and a reference most of the time. references have a separate blank line and then Closing #xxxx and/or Ref: url etc. please review push-access-guidelines for more detail. it may help to go through a bit of the repo commit history with gitk --all + down button to quickly get an idea of what is acceptable

@cmeister2
Copy link
Contributor Author

usually in a pr you would squash your incremental work together into one commit, unless they are truly separate, and then rebase before landing. you can judge whether that is the case here. your commit will need an explanation and a reference most of the time. references have a separate blank line and then Closing #xxxx and/or Ref: url etc. please review push-access-guidelines for more detail. it may help to go through a bit of the repo commit history with gitk --all + down button to quickly get an idea of what is acceptable

I've rebased the nit comment. I don't think there are any URLs to reference here. If I'm doing pushes wrong I'm happy to let someone with a bit more experience handle the merge here.

@bagder
Copy link
Member

bagder commented May 15, 2024

If I'm doing pushes wrong

The Closes #[number] line was missing in some previous commits.

@cmeister2
Copy link
Contributor Author

If I'm doing pushes wrong

The Closes #[number] line was missing in some previous commits.

Ah ok - I didn't have a corresponding issue created for this work.

@bagder
Copy link
Member

bagder commented May 15, 2024

It should say Closes for the PR and Fixes for the issue, if there is one.

Replace "chore" with "ci" for renovate's semantic
type, and include digests with "pin" and
"pinDigest" as ci operations.

Closes #13644
WolfSSL/WolfSSH use a different versioning scheme;
stable builds end with `-stable`. Renovate requires
some extra configuration to extract the version
from these types of tags.

Closes #13644
@bagder bagder closed this in a884885 May 15, 2024
bagder pushed a commit that referenced this pull request May 15, 2024
WolfSSL/WolfSSH use a different versioning scheme;
stable builds end with `-stable`. Renovate requires
some extra configuration to extract the version
from these types of tags.

Closes #13644
@bagder bagder deleted the renovate/configure branch May 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

None yet

4 participants